History | Log In     View a printable version of the current page. Get help!  
Issue Details [XML]

Key: CHD-1367
Type: Bug Bug
Status: Open Open
Assignee: Unassigned
Reporter: Robert Middleswarth
Votes: 2
Watchers: 2
Operations

Clone this issue
If you were logged in you would be able to see more operations.
Cerberus Helpdesk

[Parser] There isn't enough error checking before the unlink() call to trap all failing mail

Created: 06/Aug/09 11:30 PM   Updated: 09/Jan/10 03:20 PM
Fix Version/s: Sea of 1000 Wishes

Original Estimate: Unknown Remaining Estimate: Unknown Time Spent: Unknown
File Attachments: 1. Text File chd-1367.patch (0.6 kb)



 Description   
Most of it is outlined in this forum post.

http://forums.cerb4.com/showthread.php?t=2270

The simple issues is that function _parseFile($full_filename) { doesn't check for error before calling @unlink($full_filename); so the file gets deleted no mater what and only moved to failed if you have code in place to trap a certain error. I see several errors that could result in the lose of emails. At a min that function needs updated with code to check for errors and move the to fail instead of removing it on fail.

Thanks
Robert

 All   Comments   Work Log   Change History      Sort Order:
Comment by Robert Middleswarth [14/Oct/09 03:37 PM]

Comment by Robert Middleswarth [25/Oct/09 08:33 PM]
Looks like someone else seeing the same problem as well.

http://www.cerb4.com/forums/showthread.php?t=2468

Thanks
Robert

Comment by Robert Middleswarth [31/Oct/09 07:58 PM]
It looks like another person is having this theoretical problem as well. He posted in the existing thread.

http://www.cerb4.com/forums/showthread.php?t=2399

Thanks
Robert

Comment by Joe Geck [WGM] [28/Dec/09 11:48 AM]
Older thread in the forums that Robert has been posting in. He referenced this JIRA issue so I thought I'd do a linkback along with bumping the thread.
http://www.cerb4.com/forums/showpost.php?p=12523&postcount=1

Comment by Robert Middleswarth [09/Jan/10 03:18 PM]
For those who need a quick fix for this issue I attached and patch and here is a link to my current code I am using. When I turn this into an proper fix these links will can that code.

Thanks
Robert

For Cerb5. http://github.com/rmiddle/cerb5/tree/jira/chd-1367\
For Cerb4. I will need to updated later since the fix is in my main line.

Thanks
Robert

Comment by Robert Middleswarth [09/Jan/10 03:20 PM]
This isn't a proper fix this is just to make sure you don't lose any emails.

Thanks
Robert