History | Log In     View a printable version of the current page. Get help!  
Issue Details [XML]

Key: CHD-690
Type: Improvement Improvement
Status: Resolved Resolved
Resolution: Fixed
Assignee: Unassigned
Reporter: Joe Geck [WGM]
Votes: 6
Watchers: 5
Operations

Clone this issue
If you were logged in you would be able to see more operations.
Cerberus Helpdesk

[Open Ticket / Send Mail] No error on empty requester field makes it appear the ticket is saved when it actually is not

Created: 29/May/08 01:33 PM   Updated: 25/Apr/10 11:30 AM
Fix Version/s: 5.0 RC1

Original Estimate: Unknown Remaining Estimate: Unknown Time Spent: Unknown
File Attachments: 1. Text File CHD-690.patch (1 kb)
2. Text File cerb4-chd-690.patch (4 kb)
3. Text File cerb5-chd-690.patch (4 kb)

Issue Links:
Duplicate
 
This issue is duplicated by:
CHD-674 Compose should force entry of an emai... Minor Closed

xP Priority: 3 - Would Be Nice


 Description   
Summary:
On the "Open Ticket" or "Send Mail" screens, if you neglect to fill in a requestor - the form submits just fine with no error messages, but no actions are performed.

Solution:
There should be some kind of validation on this (either JS or PHP) rather than just returning a blank form.

Note:
http://www.cerb4.com/forums/showthread.php?t=984


 All   Comments   Work Log   Change History      Sort Order:
Comment by Joe Geck [WGM] [04/Jul/08 07:12 PM]
Verified as a valid usability issue. Would be a definite improvement if there was some kind of error message.

Comment by Jeff Standen [WGM] [14/Nov/08 12:09 AM]
@Mike
See what you can do with this. We have examples of live validation on the login form and Worker Config and a few other places. You shouldn't need to use the email validation (it doesn't do multiples), just "required".

Comment by Joe Geck [WGM] [20/Mar/09 04:34 PM]
Note:

Also keep in mind that you can create broken tickets by inputting an invalid address, where no requesters are actually created. It sounds like a user was using it as a log message tool and inputting a traditional name as the requester, e.g. Joe Geck (no @example.com). They thought this was by design when it is clearly not, I expect phone call logging will be the better alternative when it's done.

Comment by Joe Geck [WGM] [17/Jun/09 04:12 PM]
Update this thread when completed.
http://www.cerb4.com/forums/showpost.php?p=10609&postcount=6

Add 'send mail' to this list too as it behaves like 'open ticket'.

Comment by Joe Geck [WGM] [18/Aug/09 02:16 PM]

Comment by Joe Geck [WGM] [18/Aug/09 02:20 PM]
I changed the title and description from "log message" to "open ticket" which is the more recent Cerb4 language we use.

Comment by Peter McConaghy [22/Sep/09 12:37 AM]
I find it really really really really really really frustrating that issues like this seem to hang around without being fixed.
I've just lost 20+mins of work because of this bug. And now I find it's been around for over a year. Not impressed.

Comment by Joe Geck [WGM] [22/Sep/09 11:42 AM]
^^^ Update Peter's open thread in the forums when completed.
http://www.cerb4.com/forums/showpost.php?p=12200&postcount=1

Comment by Joe Geck [WGM] [10/Oct/09 11:38 AM]
Stumbled on this one today and even though I already noted this in the comments, the problem also exists in "Send Mail". Decided to finally tweak the title and description to reflect that.

Comment by Joe Geck [WGM] [19/Oct/09 12:19 PM]
Another thread where the "reset everything with no error" behavior was noticed.

http://www.cerb4.com/forums/showpost.php?p=12667&postcount=11

Comment by Robert Middleswarth [24/Jan/10 07:37 AM]
I tired to update/use the orginal patch attached but things have just changed to much for me to make it work. I instead copied the way the success message was generated and displaying a failure message instead. With translation support.

As normal here are the linkes to my cerb4 / cerb5 branches were I will be keeping the patches up to date.

cerb4 - http://github.com/rmiddle/cerb4/tree/jira/chd-690
cerb5 - http://github.com/rmiddle/cerb5/tree/jira/chd-690

Thanks
Robert

Comment by Jeff Standen [WGM] [25/Apr/10 11:30 AM]
Fixed in 5.0 RC1