History | Log In     View a printable version of the current page. Get help!  
Issue Details [XML]

Key: CHD-906
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Assignee: Unassigned
Reporter: Joe Geck
Votes: 0
Watchers: 0
Operations

Clone this issue
If you were logged in you would be able to see more operations.
Cerberus Helpdesk

[Worker] Forgetting to fill in the name fields when creating a new worker makes it impossible to edit later

Created: 07/Nov/08 03:11 AM   Updated: 13/Nov/08 09:00 PM
Fix Version/s: 4.0 - Milestone #21

Original Estimate: Unknown Remaining Estimate: Unknown Time Spent: Unknown

Value: 1 - Must Have


 Description   
Summary:
Forgetting to fill in the name fields when creating a new worker makes it impossible to edit later. Where it would normally print "last, first" name in the left column, a blank slot will appear. Now there is no clickable link to bring up the edit options.

Steps:
1) Go to 'helpdesk setup' -> 'Worker' (tab)
2) Create a new worker but only fill in the e-mail address
3) Save Changes

Result:
Observe the blank slot in the left column where "last, first" name would normally appear. Notice there is no name to click and thus the worker cannot be modified from the GUI.

 All   Comments   Work Log   Change History      Sort Order:
Comment by Jeff Standen [WGM] [12/Nov/08 09:03 PM]
Alright, it seems like was possible if you disable Javascript (which wouldn't happen, but we need to handle it anyway).

Now the worker's e-mail address will be shown in the list if the name is somehow blank. The first name will default to "Anonymous".

Comment by Joe Geck [13/Nov/08 08:29 PM]
Verified fixed as of dev build 797.

As Jeff said, creating a worker with no name results in the first name of 'Anonymous', which will appear in the Worker list sidebar as 'Anonymous'. The no-name worker can be modified, deleted, or left as is and will function as expected (simply without a last name).

Comment by Joe Geck [13/Nov/08 09:00 PM]
I'm going to leave this is a reminder/note in case it somehow comes up again with the tabbed interface. Keep in mind that this issue, as is, has been fixed.

This is in response to Jeff's comment about this only being possible if you disable Javascript -- referring to the validation checker that will lock the 'save changes' button if you choose not to enter a first name (red warning "Can't be empty!"). Ironically I don't turn off Javascript when I test so apparently I was getting the bug legitimately; meaning it can happen in regular practice.

When I was verifying the fix that went in, I found out that you can effectively "turn off" the checker as long as you don't "refresh" the Workers tab. If you simply click 'helpdesk setup' -> 'Workers' (tab) you will be presented with a ready-to-go "Add Worker" form. For some reason the validation checker will not be active and you can simply skip the first name (no warning will appear), add an e-mail address and save changes.

That is how I was getting the no-name to occur in the first place.

It's only if you "refresh" the Worker tab by clicking 'add new worker' where the validation checker seems to kick in and lock you from saving changes.

Like I said this has no impact on this issue. It's fixed even if you effectively do pass the validation checker and forget to add a first name, with the "Anonymous" worker. Nevertheless I assume it's possible to cause some other issues like saving mis-matched passwords, no password, etc if you attempt to bypass the validation checker. This would take some more testing on my part. But even if you did get past the system, it would be a minor inconvenience, as you could always login with a different worker and correct the mistake.

Anyway I just wanted this on the record and here seemed like the natural place.